[SOLVED] DoubleClick plugin not working

raul_hijosa_nieto · May 4, 2018, 11:13am

Hi,

Since Apr,5 we noticed that no ads (pre and postrolls) were shown in our videos. After a hard debugging work we found out that something must have changed in the code of the ima sdk and made the fix in the doubleClick plugin.

Instead of creating the adReques object empty we use the constructor. This is the file we have changed

/modules/DoubleClick/resources/mw.DoubleClick.js

In line 931: change:
var adsRequest = {};
for:
var adsRequest = new google.ima.AdsRequest();

Cheers
Raúl Hijosa

jess · May 4, 2018, 11:34am

Hi @raul_hijosa_nieto,

Thank you for your report. I will forward it to the player’s development team.
It would be best if you could submit a pull request with a fix to the original:

github.com

kaltura/mwEmbed/blob/master/modules/DoubleClick/resources/mw.DoubleClick.js

(function ( mw, $ ) {
    "use strict";

    mw.DoubleClick = function ( embedPlayer, callback, pluginName ) {
        this.init( embedPlayer, callback, pluginName );
    };
    mw.DoubleClick.prototype = {
        // The bind postfix to keep track of doubleclick bindings.
        bindPostfix: '.DoubleClick',

        // The content video element.
        content: null,

        // Global volume holder.
        globalVolume: 1,

        // IMA SDK Ad Loader.
        adsLoader: null,
        // IMA SDK Ad Manager.
        adsManager: null,

This file has been truncated. show original

If you could also elaborate as to the exact error you got, it would also be much appreciated.

Thanks again,

oren_melamed · May 4, 2018, 3:29pm

Thank you @raul_hijosa_nieto.
Issue has been identified a couple of hours after IMA released their fix and it has been patched across all hosted versions.
The issue began with after IMA released v3.205.0: https://developers.google.com/interactive-media-ads/docs/sdks/html5/v3/history

You analysis was correct, see fix here: https://github.com/kaltura/mwEmbed/commit/31138a55db362eaf7209c6e17629346fd74c59dd

If you are a user of the library, and are using it directly please use 2.69 which will be released next week.